wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

Fix side location conflict #117

Closed echeipesh closed 3 years ago

echeipesh commented 3 years ago

Pull request type

Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Sometimes reading the input features fails with `com.vividsolutions.jts.geom.TopologyException: side location conflict` This appears to be because the precision reduction turns tiny pockets and slivers into invalid geometries. This issue is handled better by later version of JTS. However, it's not possible to upgrade to them right now. ## What is the new behavior? We apply `ST_Buffer(0)` to fix the invalid geometries after precision reduction. This is not ideal because because one wonders if it may introduce some other changes, but is standard fix to these types of issues until JTS version can be updated. ## Does this introduce a breaking change? - [ ] Yes - [x] No

Other information