wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

Use Validated in GFW Pro Dashboard and Forest Change Diagnostic #128

Closed jpolchlo closed 2 years ago

jpolchlo commented 2 years ago

Pull request checklist

Please check if your PR fulfills the following requirements:

Pull request type

Please check the type of change your PR introduces: - [x] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?

We have encountered bad inputs in GFW Pro Dashboard (see GP-96) which lead to topology exceptions during the intersections required for feature splitting. These are fatal exceptions.

Issue Number: N/A

What is the new behavior?

The solution should be to use the same strategy as in #122 to capture intersection problems in the input geometries by threading the use of Validated from cats into the Dashboard module.

Does this introduce a breaking change?

Other information

Note that this PR was built on top of #127 to aid in debugging.