wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

Fix ForestChangeDiagnostic error handling #133

Closed echeipesh closed 2 years ago

echeipesh commented 2 years ago

Pull request type

Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Errors from different parts of ForestChangeDiagnostic cannot be combined in the final result. This was triggered by input of invalid geometry ## What is the new behavior? Errors are combined as expected. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information This PR finally starting to include some unit tests which don't run in CI yet. Unfortunately the unit tests will still have to download the raster data, but its still an improvement to have them.