search

wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

Publish Assembly from CI #137

Closed echeipesh closed 2 years ago

echeipesh commented 2 years ago

Pull request type

Please check the type of change your PR introduces: - [x] Build related changes ## What is the current behavior? Version is read from `version.sbt` ## What is the new behavior? Version is generated from git tags and history using [sbt-dynver](https://github.com/dwijnand/sbt-dynver) plugin. ## Does this introduce a breaking change? The publish happens only on heavy tags, which have to be made either with git CLI or as part of GitHub release. The AWS role that allows writing to the S3 bucket will not be granted to anything that's not a tag, that should minimize the chances of publish process being hijacked. This process may be made more sophisticated later: - What about publishing from PRs? That would be handy to test. - We could publish from feature branch, that would allow for longer standing changes to be tested - master/develop split I don't think makes sense for this repo. A feature branch model would be a better fit. - [x] No
codecov-commenter commented 2 years ago

Codecov Report

Merging #137 (a4d94b3) into develop (b5426cf) will increase coverage by 14.38%. The diff coverage is 49.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #137       +/-   ##
============================================
+ Coverage     3.42%   17.81%   +14.38%     
============================================
  Files          261      262        +1     
  Lines         5191     5108       -83     
============================================
+ Hits           178      910      +732     
+ Misses        5013     4198      -815
Flag Coverage Δ
unittests 17.81% <49.61%> (+14.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cala/org/globalforestwatch/ValidatedWorkflow.scala 78.57% <ø> (+78.57%) :arrow_up:
...scala/org/globalforestwatch/features/Feature.scala 20.00% <ø> (+20.00%) :arrow_up:
...org/globalforestwatch/features/FeatureFilter.scala 18.18% <ø> (+18.18%) :arrow_up:
...la/org/globalforestwatch/features/FeatureRDD.scala 0.00% <0.00%> (ø)
.../org/globalforestwatch/features/FireAlertRDD.scala 0.00% <ø> (ø)
...a/org/globalforestwatch/features/GadmFeature.scala 0.00% <ø> (ø)
...org/globalforestwatch/features/GfwProFeature.scala 81.81% <ø> (+81.81%) :arrow_up:
...alforestwatch/features/PolygonIntersectionDF.scala 0.00% <ø> (ø)
...org/globalforestwatch/features/SimpleFeature.scala 0.00% <ø> (ø)
...a/org/globalforestwatch/features/WdpaFeature.scala 0.00% <ø> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c477097...a4d94b3. Read the comment docs.