Closed dagibbs22 closed 12 months ago
Yes, I tested locally with various configurations, ranging from all flags on to no flags on. The right fields were output each time and the totals matched values from a run on the same shape before I made these changes.
This looks good for the most part, just had one question on why we need to change so many layer URIs.
Also, did you test locally it created the new output correctly? It looks like the tests are failing, possibly because of your layer changes.
Attention: 322 lines
in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Files | Coverage Δ | |
---|---|---|
.../globalforestwatch/layers/FIAregionsUSextent.scala | 0.00% <ø> (ø) |
|
...atch/layers/GrossCumulAbovegroundRemovalsCo2.scala | 0.00% <ø> (ø) |
|
...atch/layers/GrossCumulBelowgroundRemovalsCo2.scala | 0.00% <ø> (ø) |
|
...forestwatch/layers/GrossEmissionsCo2OnlyCo2e.scala | 0.00% <ø> (ø) |
|
...lforestwatch/layers/GrossEmissionsNonCo2Co2e.scala | 0.00% <ø> (ø) |
|
...h/layers/GrossEmissionsNonCo2Co2eBiomassSoil.scala | 0.00% <ø> (ø) |
|
...globalforestwatch/layers/IntactPrimaryForest.scala | 0.00% <ø> (ø) |
|
...yers/JplTropicsAbovegroundBiomassDensity2000.scala | 0.00% <ø> (ø) |
|
...ayers/JplTropicsAbovegroundBiomassExtent2000.scala | 0.00% <ø> (ø) |
|
...ain/scala/org/globalforestwatch/layers/Layer.scala | 38.98% <ø> (ø) |
|
... and 45 more |
:loudspeaker: Thoughts on this report? Let us know!.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
treecoverloss
package even if they're not being used.What is the new behavior?
Does this introduce a breaking change?
Other information
I will separately make changes to the ArcPy client so that the new user options can be accessed from there.