Feature/carbon layer cleanup - Githubissues

wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK

MIT License

10 stars 8 forks source link

Feature/carbon layer cleanup #199

Closed dagibbs22 closed 11 months ago

dagibbs22 commented 12 months ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Sources for carbon layers were sometimes unclear or inconsistently named.
Emissions carbon layers were duplicated and sometimes didn't specify biomass+soil or soil only.

What is the new behavior?

Carbon layers have clearer, more consistent sourcing now.
Emissions carbon layers clearly refer to biomass+soil or soil-only. Code refactored to reflect changes.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A