search

wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

GTC-2622 Add a test for gfwpro_dashboard #202

Closed danscales closed 10 months ago

danscales commented 11 months ago

GTC-2622 Add test for gfwpro_dashboard

I added several input files, and had to change the return value of GfwProDashboardAnalysis().

Also, I had to add ability to pin a version of a dataset (see second commit), since we need to ping the integrated_alerts version so that the dashboard results from the test are constant.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (054a820) 14.69% compared to head (dada6df) 18.11%.

Files Patch % Lines
...tats/gfwpro_dashboard/GfwProDashboardCommand.scala 0.00% 7 Missing :warning:
...g/globalforestwatch/summarystats/SummaryMain.scala 0.00% 1 Missing :warning:
...lobalforestwatch/summarystats/afi/AFiCommand.scala 0.00% 1 Missing :warning:
...ualupdate_minimal/AnnualUpdateMinimalCommand.scala 0.00% 1 Missing :warning:
.../carbon_sensitivity/CarbonSensitivityCommand.scala 0.00% 1 Missing :warning:
...ch/summarystats/carbonflux/CarbonFluxCommand.scala 0.00% 1 Missing :warning:
...ch/summarystats/firealerts/FireAlertsCommand.scala 0.00% 1 Missing :warning:
...nge_diagnostic/ForestChangeDiagnosticCommand.scala 0.00% 1 Missing :warning:
...ch/summarystats/gladalerts/GladAlertsCommand.scala 0.00% 1 Missing :warning:
...ts/integrated_alerts/IntegratedAlertsCommand.scala 0.00% 1 Missing :warning:
... and 1 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #202 +/- ## ========================================== + Coverage 14.69% 18.11% +3.41% ========================================== Files 291 291 Lines 6484 6488 +4 ========================================== + Hits 953 1175 +222 + Misses 5531 5313 -218 ``` | [Flag](https://app.codecov.io/gh/wri/gfw_forest_loss_geotrellis/pull/202/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wri) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/wri/gfw_forest_loss_geotrellis/pull/202/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wri) | `18.11% <29.16%> (+3.41%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wri#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danscales commented 10 months ago

Thanks for the review and re-review!