search

wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

GTC-2641 Add the boot script that we use for EMR nodes #209

Closed danscales closed 10 months ago

danscales commented 10 months ago

GTC-2641 Add the boot script that we use for EMR nodes

This script has not been under source code control before. As the fix for GTC-2641, I added a new line loading a specific version of libcurl (version 7.76.1). Otherwise, we always get the newest version of libcurl (currently version 8.5), and that is causing the issue (socket disconnects on repeated access to S3). I'm not yet sure if it is a bug in the newer versions of libcurl or an intended feature.

danscales commented 10 months ago

Very minor, but I think main/resources is typically for static files you want to load in the JAR for the application to use. But this is something called outside the JAR. Maybe it'd fit better just under the scripts folder? But not a big deal either way.

Thanks for the review! Sure, your suggestion definitely makes sense. I moved the script to the scripts/ directory.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (196d3bb) 18.15% compared to head (81111ae) 18.15%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #209 +/- ## ======================================= Coverage 18.15% 18.15% ======================================= Files 291 291 Lines 6473 6473 ======================================= Hits 1175 1175 Misses 5298 5298 ``` | [Flag](https://app.codecov.io/gh/wri/gfw_forest_loss_geotrellis/pull/209/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wri) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/wri/gfw_forest_loss_geotrellis/pull/209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wri) | `18.15% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wri#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.