Update tree cover gain to use five year periods - Githubissues

wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK

MIT License

10 stars 8 forks source link

Update tree cover gain to use five year periods #214

Closed jterry64 closed 6 months ago

jterry64 commented 8 months ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[X] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[X] Check the commit's or even all commits' message styles matches our requested structure.
[X] Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: GTC-2721

What is the new behavior?

Tree cover gain now uses five year periods instead of just being boolean
For annualupdate_minimal, the output schema has changed from is__umd_tree_cover_gain to umd_tree_cover_gain__period. @manukala6 you'll need to let the frontend know this when you do the update.
For other analyses that check tree cover gain, I changed to just checking if the gain is a non-empty string
Does this introduce a breaking change?
[X] Yes
[ ] No

Schema change as mentioned above. @dagibbs22 you might want to quickly check this doesn't affect your carbon analyses, I kept the schema as is.

jterry64 commented 8 months ago

I'm going to hold off on merging this until we decide if it should be before or after TCL 2023