The result of the following changes is that we now only call the data API exactly once for GFWPro dashboard analyses (previously four times), and we no longer call the data API at all for the FCD and AFi analyses.
Remove umd_glad_landsat_alerts entry from the raster-catalog-pro.json. It is not used for GFWPro analyses (only integrated alerts is used for Dashboard), but causes a Data API call because of its use of 'latest'. I needed to adjust GladAlertsSuites, so it create GladAlerts() lazily, since that class is initialized even during GFWPro test runs.
Removed redundant call to GfwConfig.get() in SummaryMain.scala. I'm not sure why this is here (it's been in for a while), since all the analyses have their own call to GfwConfig.get(). Maybe this was for debugging and mistakenly left in?
Make use of pinning versions that I added for the dashboard tests. For the FCD and AFi analyses, I supply config option to pin the version of gfw_integrated_alerts, since these analyses don't need to access integrated alerts, and the pinning means we won't call the data API to get the latest version.
Reduce calls to Data API for GFWPro analyses
The result of the following changes is that we now only call the data API exactly once for GFWPro dashboard analyses (previously four times), and we no longer call the data API at all for the FCD and AFi analyses.
Remove umd_glad_landsat_alerts entry from the raster-catalog-pro.json. It is not used for GFWPro analyses (only integrated alerts is used for Dashboard), but causes a Data API call because of its use of 'latest'. I needed to adjust GladAlertsSuites, so it create GladAlerts() lazily, since that class is initialized even during GFWPro test runs.
Removed redundant call to GfwConfig.get() in SummaryMain.scala. I'm not sure why this is here (it's been in for a while), since all the analyses have their own call to GfwConfig.get(). Maybe this was for debugging and mistakenly left in?
Make use of pinning versions that I added for the dashboard tests. For the FCD and AFi analyses, I supply config option to pin the version of gfw_integrated_alerts, since these analyses don't need to access integrated alerts, and the pinning means we won't call the data API to get the latest version.