Burned Areas Partitioning and Other Fixes - Githubissues

wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK

MIT License

10 stars 8 forks source link

Burned Areas Partitioning and Other Fixes #92

Closed jterry64 closed 3 years ago

jterry64 commented 3 years ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[X] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[X] Check the commit's or even all commits' message styles matches our requested structure.
[X] Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Uses hash then range partitioning for burned areas.

What is the new behavior?

For burned areas, just use GeoSpark quadtree partitioning since it works best.
Make sure burned areas is left dataset in spatial join, so partitioning/indexing is done on burned areas dataset.
Fix issue where sometimes buffer geometry trick turns Polygons into MultiPolygons
Fix bug with WDPA feature ID not being parsed correctly
Use VIIRS grid for burned areas instead of MODIS grid

Does this introduce a breaking change?

[ ] Yes
[X] No