Please check if your PR fulfills the following requirements:
[ ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[ ] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[ ] Check the commit's or even all commits' message styles matches our requested structure.
[ ] Check your code additions will fail neither code linting checks nor unit test.
Pull request type
Please check the type of change your PR introduces:
- [x] Bugfix
- [x] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
## What is the current behavior?
The database displays the name in the owner field with a percentage. For some Denmark plants, the percentage ownership is included in the owner name. For example, a plant wholly owned by Vattenfall may have the owner name reported as '100% Vattenfall' instead of 'Vattenfall'. The database does not join well with owner data from the GLEIF database.
Issue Number: 24 and 27
What is the new behavior?
Strings assigned to the owner field of Denmark plants are modified to remove any percentage prepended to the owner's entity name.
The table in file resources/master_lei_concordance.csv is used to match and append LEI codes to the database output in a new column labeled lei_code.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces: - [x] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?The database displays the name in the owner field with a percentage. For some Denmark plants, the percentage ownership is included in the owner name. For example, a plant wholly owned by Vattenfall may have the owner name reported as '100% Vattenfall' instead of 'Vattenfall'. The database does not join well with owner data from the GLEIF database.
Issue Number: 24 and 27
What is the new behavior?
resources/master_lei_concordance.csvis used to match and append LEI codes to the database output in a new column labeledlei_code.Does this introduce a breaking change?
Other information