wri / wri_sites

WRI profile
2 stars 2 forks source link

Update Share link to use "X" with optional tweet tag add-on #234

Closed mariacha closed 8 months ago

mariacha commented 11 months ago

Coming out of https://github.com/wri/wri-espanol/issues/2, share block links that appear on events pages, among others, are not translatable. This includes the text of the links (Twitter, LinkedIn), the aria text on the buttons, and the suffix on tweets (via @WorldResource).

This issue would fix that and anything else?

Dev note: PR opened for this here: https://github.com/wri/wri_sites/pull/233 but doesn't allow changing the name of the links, so Twitter is still that.

Update: Have block be translatable part of config so it could be changed per site and per translation if needed.

To test

mariacha commented 11 months ago

@wthomaswri I made this followup ticket for Espanol -- was there more to the hope for translating the share links?

wthomaswri commented 11 months ago

hi @mariacha i think being able to manually adjust the titles would be great. I think Twitter would eventually change to X and not sure what else in the future so it'd probably be something we should move across all sites

mariacha commented 11 months ago

Ah, sure that makes sense.

wthomaswri commented 10 months ago

looks good @mariacha

mariacha commented 10 months ago

This is ready for review on develop for Brasil: https://develop-wri-brasil.pantheonsite.io/publicacoes/956-release-items

mariacha commented 9 months ago

This is ready for review on the remaining IOs: China: https://develop-wri-china.pantheonsite.io/en/research/release-957 Indonesia: https://develop-wri-indonesia.pantheonsite.io/id/publikasi/957-melepaskan Espanol: https://develop-wri-espanol.pantheonsite.io/publicaciones/release-957-958

wthomaswri commented 9 months ago

Looks good @mariacha