wri / wri_sites

WRI profile
2 stars 2 forks source link

Multilingual title for Person blocks embeded via layout does not take. #294

Open mariacha opened 3 months ago

mariacha commented 3 months ago

Describe the bug When fixing https://github.com/wri/wriflagship/issues/1047 I introduced a bug where the overriding title DOES display on Paragraphs, but that means the label does not display on blocks embeded via layout builder. So the goal here is to revert https://github.com/wri/wri_sites/commit/a9d3e89ec34ad5a940973435889c765633d287c1 and fix the bug with a paragraph preprocessing function instead, which will set the "label" for the field equal to the block's title (based on the current language).

Query to get pages to check:

SELECt * FROM paragraphs_item LEFT JOIN paragraphs_item_field_data USING (id) WHERE paragraphs_item.type='person_listing'

Dev tasks

mariacha commented 3 months ago

This has been fixed on Flagship. Since Flagship is not multilingual, the only thing to test is that Person Listing paragraphs continue to have the correct, unique titles: https://develop-wriflagship.pantheonsite.io/testing-experts-intro-paragraphs https://develop-wriflagship.pantheonsite.io/simple-page-test

mariacha commented 2 months ago

Bug found on https://develop-wriflagship.pantheonsite.io/cities -- experts should say "Featured Cities Experts"