wri / wri_sites

WRI profile
2 stars 2 forks source link

Zoom webform issues #314

Open mariacha opened 1 month ago

mariacha commented 1 month ago
  1. The webform's ip address (saved as remote_addr) does not match the value pulled by the [webform_submission:ip-address] on the Pantheon live site only.
  2. Also verify that the tracking info for email is being set. -- ignore this, we need more information

Dev tasks

komejo commented 1 month ago

@mariacha In PR's: https://github.com/wri/wri_sites/pull/319 https://github.com/wri/wriflagship/pull/1231

Note: in researching how to implement this I noticed the Pantheon docs mentioning remote_addr and how it "takes into account if the X-Forwarded-For header", but also had a big Warning about the global CDN. Just to be safe I used the X-Forwarded-For header as the likely best source with remote_addr as the fallback. In most cases I'd just use remote_addr but since WRI is a truly global client I thought a more comprehensive approach might be best.

mariacha commented 1 month ago

Ok, I tested this out on develop and it's ready to go to live.

mariacha commented 1 month ago

@cpmadera This change went up with today's deploy. Can you let me know if the IP addresses are coming through correctly when you get a moment?