Bug cleanup - Githubissues

ddkohler commented 5 years ago

[x] fix resonance conditions of default hamiltonian (previously untested because all system frequencies were set to zero).
[x] move time axis determination outside of pulse_class and into scan object.
[x] in mixed, send output to the same rotating frame (namely, the lab frame where DC output means zero frequency)
[x] validate correct phase output properties (put in scripts folder)
[x] package a script for investigating the phase behavior of scan signal (put in scripts folder)
[x] tweak target scripts so that they still work

ddkohler commented 5 years ago

@ksunden hoping to get your help looking at the gpu side of this. I have no idea if it still works given the changes I've made.

ddkohler commented 2 years ago

well, where were we? Ah yes, one remaining task. Let's create an issue and PR what we have.

ddkohler commented 2 years ago

@pcruzparri I am happy with the state this PR now. Please review at your convenience.

wright-group / WrightSim