wright-group / WrightSim

A simulation package for multidimensional spectroscopy.
MIT License
4 stars 0 forks source link

sign error #39

Closed ddkohler closed 4 years ago

ddkohler commented 4 years ago

Tested code with non-zero resonance frequency; Found anti-resonant conditions with Hamiltonians. Electric field pulse signs mirror the signs of the hamiltonians (i.e. we currently simulate w_ag + w_laser)

cf. Kohler 2017 Eqns. S9-14

darienmorrow commented 4 years ago

@ksunden is this ready?

ksunden commented 4 years ago

I still want to check the CUDA code (manually) and have not taken the time to do so...

@darienmorrow Is there a timeline that you would like this merged for?

darienmorrow commented 4 years ago

@ksunden can it be done by 2020-05-01?

ksunden commented 4 years ago

@darienmorrow I think that works, I'll plan on attackin it later this week

ksunden commented 4 years ago

I am satisfied, just made some changes to target.py so that it runs and produces a graph, as that is more useful than what it was... Do think we should spend some time making proper examples/docs at some point... but right now is not the time, at least for me.