search

wright-group / WrightSim

A simulation package for multidimensional spectroscopy.
MIT License
4 stars 0 forks source link

WT data conversion #45

Closed kameyer226 closed 1 year ago

kameyer226 commented 1 year ago

Closes #44 . Comparison between original summing of values target.py and new summing shows differences, there may be an error in how summing is occurring. Branch name is misleading.

ddkohler commented 1 year ago

@kameyer226 I think you did not mean to delete those files?

ddkohler commented 1 year ago

Comparison between original summing of values target.py and new summing shows differences, there may be an error in how summing is occurring.

This sounds problematic. Have you figured out the nature of the differences? We probably don't want to merge this until we at least understand the differences...

kameyer226 commented 1 year ago

Will close this PR and introduce a separate PR with changes more in keeping with reviewer's thoughts on incorporating wt data conversion within the scan module