search

wright-group / WrightTools

Tools for loading, processing, and plotting multidimensional spectroscopy data.
http://wright.tools
MIT License
17 stars 9 forks source link

contourf needs testing with new quick2D #1191

Open ddkohler opened 2 days ago

ddkohler commented 2 days ago

https://github.com/wright-group/WrightTools/blob/7a9c58490b2ecec56783ada7e1fa01a2b413c557/WrightTools/artists/_base.py#L156-L158

when pixelated = False, this clause can run without "vmin" kwarg existing (per James)

ddkohler commented 1 day ago

I believe the fix is just changing kwargs["vmin"] and kwargs["vmax"] to vmin and vmax

We should make a test for this.

ddkohler commented 1 day ago

upon more inspection, it looks like this is one of the growing pains of our switch to using norm arguments around v3.5.1

using versions before this does not cause this error (James has verified)

I think these problem clauses need to screen for, and handle, norm in the kwargs, but it's clear testing should be incorporated to make the contourf/contour implementations robust.