search

wright-group / attune

Tools for tuning optical parametric amplifiers and multidimensional spectrometers.
MIT License
3 stars 3 forks source link

Poor visual representation in attune.workup.tune_test #90

Open DLafayetteII opened 4 years ago

DLafayetteII commented 4 years ago

image

Issues with attune.workup.tune_test representation: 1) the vertical axis is so large that the quality of fit is obscured 2) the color map is signed, even despite the cbar being correctly colored 3) the spline is flipped from the data. Unclear whether the fit points match the data orientation or the incorrect spline orientation, needs to be checked.

Here is a copy of the folder containing the data behind the linked image:

ksunden commented 4 years ago

Colormap problem is wright-group/PyCMDS#227

That said, the tuning methods should all specify their colormap, given that they do so to the colorbar anyway....