search

wright-group / yaqc-cmds

A qt-based graphical client for yaq with a focus on coherent multidimensional spectroscopy in the Wright Group.
MIT License
7 stars 4 forks source link

Spectrometers: destination has limits imposed by current grating #339

Closed ddkohler closed 3 years ago

ddkohler commented 3 years ago

e.g. on the visible grating, but destination grating is IR, the field does not let me write a destination outside the current grating bounds.

workaround is to switch grating first and then move position, but note that this presents a problem if the grating limits do not overlap.

ksunden commented 3 years ago

This is not easy to fix... we read the limits from the daemon, and limits for other gratings are not visible without setting the turret.

note that it is not a problem if limits do not overlap, it will simply go to the nearest valid position.

Note also that I believe all spectrometers will overlap as they all provide 0 nm, in my experience.

untzag commented 3 years ago

I agree with @ksunden on this one. The client has no way to know what the limits will be until the turret is actually changed. We could build workarounds, of course, but they would just add fragility and complexity without significant gain in my opinion. Marking as WONTFIX.

@ddkohler feel free to re-open or comment if you disagree

ddkohler commented 3 years ago

I am wondering if the destination position form can just be unlimited in its inputs, while the daemon will just go to a limit if it is out of bounds?

untzag commented 3 years ago

that works, I guess... can you write out an example of what steps you would take and what you want the behavior to be?

ksunden commented 3 years ago

I don't like that plan, I think it is useful to have the feedback about the limits (even when they change, you know you changed the turret)