Closed jrp2014 closed 2 years ago
Wow, this is awesome! Thanks for the cleanup! I'm always glad to hear people are getting something out of it.
These changes go a long way to improve readability (eliminating warnings, using explicit imports, tossing unused variables is always a plus in my book 👍 )
In terms of HLinit/linter compliance, I don't really have preference there, just to err on the side of consistency for this project, which this PR does.
On gitlab actions, not sure why the golden files aren't being picked up: I started this project before github actions were a thing and since it's an educational tool, I think they are "nice to have" but not something I'll spend a lot of time on if the haskell-ci
auto-generated files don't easily work.
I'm going to give tentative approval, and in a few days I'll squash and merge. Thank you!
Thanks for keeping this great tutorial going.
A gratuitous PR. This allows scheme to be build using only cabal to complement the stack-based build.
At the same time, I
.gitignore
to match, and added a basic github workflow. (I also tried adding ahaskell-ci
based workflow for travis and github, but these failed to pick up the test files correctly (the golden test failed trying to parse<stdin>
for reasons unknown)deriving
to be used.StrictData
pragma to reduce the chance of space leaks. I didn't makeIFunc
inLispVal.hs
anewtype
which would further have reduced laziness.)Anyway, I hope that you find some of these changes of some use.