search

writeas / go-writeas

Go client for the Write.as API
MIT License
22 stars 11 forks source link

use NewClientWith for tests #17

Closed ghost closed 5 years ago

ghost commented 5 years ago

this just switches to use NewClientWith for tests

ghost commented 5 years ago

This wasn't really needed. I can make use of NewClientWith

thebaer commented 5 years ago

This looked like a reasonable change... why wasn't it needed?

ghost commented 5 years ago

Because NewClientWith already provides the same functionality. I think 😁

ghost commented 5 years ago

The changes look like just using NewClientWith for tests but the first commit here was to change the new client methods to take a URL parameter, https://github.com/writeas/go-writeas/pull/17/commits/d622687fa8c1a0518bf533a33db6fd362c2b43e6.

I can open a new cleaner PR with just the test changes if you like.