search

writeas / writeas-cli

Command line client for Write.as / WriteFreely
https://write.as/apps/cli
GNU General Public License v3.0
113 stars 20 forks source link

Use writeas.v2 #20

Closed abhinav closed 5 years ago

abhinav commented 5 years ago

Seems to me that the v2 branch of go-writeas is where new development is being done so this changes writeas-cli over to use that.

It also introduces a go.mod and go.sum to pin to dependencies consistently.

(Minor note about the imports: I ran goimports on those two files so the imports were grouped into standard library and everything else. Separating standard library and other imports into groups is suggested in the Go Wiki. That said, I'm happy to reverse that if you prefer your style.)

thebaer commented 5 years ago

Thanks! I actually hadn't updated the develop branch in a while, and was doing all of my current work on local-workflow. So develop is up to date now for any future changes you want to make, and already points to writeas.v2. But I think the go.mod / go.sum additions are good ones. Maybe create a PR just for those?

thebaer commented 5 years ago

As for goimports, if you want to run that on all files and update the Coding conventions to match, I think that's a fine change to make.

thebaer commented 5 years ago

Since the stated purpose of this PR is finished already, I'll close this. Feel free to create individual PRs for each of those other previously mentioned changes.

abhinav commented 5 years ago

Sounds good!

go.mod change: #21 goimports: #22