Open a-mt opened 5 years ago
Hi @a-mt, this is actually something that is being discussed over on our phabricator https://phabricator.write.as/T596
The errors were a bit all over, there have been a lot of changes since you opened this - sorry about that. There will likely be more changes needed to clean things up further as well.
If you are still interested in working on this let us know, and maybe come by our phabricator to discuss details.
Adds the command "config", to be able to easily edit the user configurations.
I know you didn't ask for it, feel free to reject it.
If you don't, here's some reservations that I have:
I don't understand how the errors are handled
commands.go:
fonts.go:
options.go:
posts.go:
Basically, I don't understand in which cases errors should be returned rather than printed, and with which method :/
When the user doesn't give the right options / arguments:
Shouldn't we print the command usage and its options, using
cli.ShowSubcommandHelp(c)
(the same output aswriteas COMMAND --help
) and putting the usage in the fieldUsageText
(cli.go), rather than callingcli.NewExitError("usage: writeas ...", 1)
?Looking forward to your feedback!