search

writeas / writeas-gtk

Write.as desktop app for elementaryOS (a fork of writeas-gtk)
https://write.as/apps/desktop
GNU General Public License v3.0
21 stars 7 forks source link

Use ModeSwitch #10

Closed cassidyjames closed 5 years ago

cassidyjames commented 5 years ago

This is a work in progress. It mostly works, but I am getting an issue when restoring the dark mode: the switch is not set to active.

screenshot from 2018-12-17 12 21 11

screenshot from 2018-12-17 12 21 18

Note that this does not introduce a dependency on Granite; instead, the Granite ModeSwitch is pulled into the codebase. Either way could work, it is up the @writeas developers.

Will close #9 if/when merged.

thebaer commented 5 years ago

Love it! This looks really nice. I didn't know about the Granite stuff before. Will definitely be looking through that in the future.

I figured out what was causing the bug -- just an extra var in there. I'll get this change merged in, and grab the updated screenshots. Thanks again for all your awesome help with this!