"Show selection matches" (Ctrl-1) should select new match if cursor selects

[chrisb1978]

Follow this sequence please:

1. select some characters
2. press ctrl-1
3. select some other characters
4. press ctrl-1

Current behaviour: the first time ctrl-1 is pressed, (step 2.) all occurences of the characters are displayed (expected behaviour). the second time ctrl-1 is pressed though (step 4.), the highlighted matches are disabled.

More natural behaviour: i think it would feel more natural if ctrl-1 always shows the matching selections, if text is currently selected. only if NO text is selected, and ctrl-1 is pressed, should the selected matches be disabled.

hope this helps!

[writemonkey]

The problem is Ctrl+1 also works on a word under the cursor when nothing is selected.

[chrisb1978]

Ah, I see. What about the following behaviour - it would keep your current selection behaviour, as well as feeling more natural to use (i think). For this, the caret position needs to be stored when the user presses CTRL-1, e.g. like this:

When CTRL-1 is pressed..

• ..and no caret position is stored, the highlighting starts, and the caret position gets stored.
• ..and a caret position is stored, AND (a) the current caret position is equal to the stored caret position, OR (b) the caret is still in the same character sequence as before: highlighting stops.
• ..and a caret position is stored, but the current caret positions is on a different character sequence, then highlighting starts.

This would allow for highlighting to still work with just one key-combo. What do you think?

[writemonkey]

Yes, that would do it.