Closed samhavens closed 4 years ago
sigh just realized my personal computer has the max line length set to 80, and different rules for Markdown and JSON formatting, so there are extra formatting diffs... Let me know if I need to change that.
Maybe we can check the correct .vscode/settings.json
into git so it overrides local settings?
Sorry
Allow suggestions to not have text but instead just reference a pattern token by 0-index from start of pattern, and also allow tokens like this to be explicitly inflected, closing #30 and #31.
match_dict.json
andreadme
ReplaceMatcher.inflect_suggestions
is nowReplaceMatcher.process_suggestions
, since it also needs to handlePATTERN_REF
nowInflector
:inflect
is nowauto_inflect
, since it was automatically inflecting some text to match some tokenInflector
:inflect_or_lookup
, whichauto_inflect
calls, but so doesReplaceMatcher.process_suggestions
Thoughts
this is pretty cool, you can test it with:
Which isn't that cool until you look at the pattern and see how general it is. I'm not sure how much more is needed for effective LT feature parity.
HOWEVER, since you can reference pattern tokens by ID... it makes
TEMPLATE_ID
feel kinda unneeded, we could change that toFROM_PATTERN
and just use the token ID. Thoughts @melisa-qordoba ?