writer / writer-framework

No-code in the front, Python in the back. An open-source framework for creating data apps.
https://dev.writer.com/framework/introduction
Apache License 2.0
1.3k stars 73 forks source link

feat: Added redeploy confirmation if different app was already deployed using same api key #469

Closed raaymax closed 1 month ago

FabienArcellier commented 2 months ago

In this scenario, wouldn't it be simpler to use the absolute path of the folder that contains the application as a reference?

The only benefit of using app id is to support directory rename. If you go further in this direction, I would recommand to add it on the app provisionning or in the writer framework code, not in the deployment code.

alternate propsition that does not change the ui.json :

{
  "<token>": "<absolute path of project>",
  "<token2>": "<absolute path of project 2>"
}
ramedina86 commented 2 months ago

Good to close this?