Some cosmetic changes - Githubissues

writesapp / website

Website for writes.

https://writes.ga/

Do What The F*ck You Want To Public License

3 stars 0 forks source link

Some cosmetic changes #36

Closed AleksanderSkubala closed 4 years ago

AleksanderSkubala commented 4 years ago

I think it's cool to do things like:

change package name in package.json
change favicon to our bjutiful logo (package.json too)
set margin between buttons in form (AddModal.js)
set right margin in mobile version of table with all writes (WritesTable.js)
change navigate destination of breadcrumbs from '/' to '/app' in write-view (Write.js)

I propose ticket name as: feature/cosmetic-changes

AleksanderSkubala commented 4 years ago

That's what I'm talking about in part with 'right margin'

AdamSiekierski commented 4 years ago

I would also change the Home in breadcumbs to App

datejer commented 4 years ago

I would also change the Home in breadcumbs to App

I don't feel like App would fit too well. After all it's just a website and Home bacame sort of a standard in these situations. I would put the name of the app in there instead however the name is too similiar to the category name. (writes. and we named single posts Writes)

AdamSiekierski commented 4 years ago

Well, let's look at it this way: the home is landing page, and we're currently in App part of the website, which contains the writes, etc. Idk, imo App feels more coherent to how the routes and paths look like

AdamSiekierski commented 4 years ago

And maybe on smaller viewports, let's completely remove the padding of ContentWrapper? More space for table, less complexity on website. And this 15px padding doesn't feel right at all

datejer commented 4 years ago

Well, let's look at it this way: the home is landing page, and we're currently in App part of the website, which contains the writes, etc. Idk, imo App feels more coherent to how the routes and paths look like

Except, the end-user, your typical non-techy kid, doesn't care about the URLs, they don't look at them as something meaningful, you're putting way too much attention to the routes because you made the routes and feel like they're important. No. One. Will. Ever. Notice. You can't even explain routes to a non-tech-savvy person. Everyone you ask would tell you to leave it at Home from a design standpoint. There's no App there's just a website. We're using the /app route because that's the only other thing that wouldn't be associated with the main page /.

datejer commented 4 years ago

Well, let's look at it this way: the home is landing page, and we're currently in App part of the website, which contains the writes, etc. Idk, imo App feels more coherent to how the routes and paths look like

Also, if we're in the app then we're in the app's home. The app is a subset of the whole site. The home breadcrumb is an element of the app.

AdamSiekierski commented 4 years ago

Well, that's right. So let's leave it as it is :)

datejer commented 4 years ago

And maybe on smaller viewports, let's completely remove the padding of ContentWrapper? More space for table, less complexity on website. And this 15px padding doesn't feel right at all

It does feel unnecessary and takes up too much space IMO.

AdamSiekierski commented 4 years ago

Ok, so I'm taking it