Add Portland 2024 videos

writethedocs / www

The main website for Write the Docs.

http://www.writethedocs.org

Other

1.32k stars 510 forks source link

Add Portland 2024 videos #2153

Closed plaindocs closed 3 months ago

plaindocs commented 4 months ago

Super messy diff, but it should just be adding the youtube IDs. I should probably look at not mangling the whitespace, but I can't really be bothered.

📚 Documentation preview 📚: https://writethedocs-www--2153.org.readthedocs.build/

plaindocs commented 4 months ago

Do we still have to futz to generate the content in videos/*? We do that manually right?

mxsasha commented 4 months ago

Do we still have to futz to generate the content in videos/*? We do that manually right?

I think that is generated during a build with ENABLE_VIDEOS on.

plaindocs commented 4 months ago

@mxsasha take one more look please?

mxsasha commented 4 months ago

LGTM :shipit:

plaindocs commented 4 months ago

Oh boo. That'll teach me.

@mxsasha

Maybe I should just add the exception(s) in here instead https://github.com/writethedocs/www/blob/main/docs/_ext/videos.py#L136

mxsasha commented 4 months ago

Maybe I should just add the exception(s) in here instead https://github.com/writethedocs/www/blob/main/docs/_ext/videos.py#L136

Feels like the best place, yes. Or just don't regenerate video files < 2024 at all there. Saves time too.

plaindocs commented 4 months ago

ok already

At docs/_build/html/blog/newsletter-june-2019/index.html:139:

internally linking to /videos/prague/2018/tackling-technical-debt-in-the-docs-louise-fahey, which does not exist
At docs/_build/html/topics/index.html:421:

internally linking to /videos/prague/2018/tackling-technical-debt-in-the-docs-louise-fahey/, which does not exist
At docs/_build/html/videos/prague/2018/index.html:105:

internally linking to /videos/prague/2018/tackling-technical-debt-in-the-docs-louise-fahey/, which does not exist
At docs/_build/html/videos/prague/2018/index.html:108:

internally linking to /videos/prague/2018/tackling-technical-debt-in-the-docs-louise-fahey/, which does not exist

plaindocs commented 4 months ago

@mxsasha any thoughts on an easy way to exclude certain talks here?

mxsasha commented 4 months ago

I don't understand why anything from Prague 2018 is being modified? Did we not publish that talk? But the video template file isn't removed in this PR? How does the build currently succeed on main?

If your question is just to stop that talk being included in the Prague 2018 videos index, i.e. removing the broken link, I think you can remove the youtubeId from 2018.prague.speakers.yaml. But I don't understand how anything in this PR is now breaking that link, if it is not broken on main.

plaindocs commented 3 months ago

Exactly. I think it's something about flakey linters getting upgraded and changing behavior. I'll try removing the Id and seeing if that helps.