Patch the Laravel framework

wrk-flow / larastrict

Opinionated extension of a Laravel framework to help you build type safe, testable and reusable code.

https://larastrict.com

MIT License

5 stars 2 forks source link

Patch the Laravel framework #14

Open pionl opened 2 years ago

pionl commented 2 years ago

For quality improvements would be great to patch Laravel framework using cweagans/composer-patches

https://github.com/laravel/framework/pull/42564
https://github.com/laravel/framework/pull/41557
Mabe this "interface" https://github.com/laravel/framework/pull/41485 (maybe could be PHP Attribute?)
https://github.com/laravel/framework/issues/42018

The patches would be in separate composer package to make it reusable without using larastrict (and maybe optional?).

pionl commented 1 year ago

Example of how to make a patch https://github.com/easy-coding-standard/easy-coding-standard/pull/108/files

pionl commented 1 year ago

Expression support in various where conditions

  413    Parameter #4 $second of method                                                                   
         Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model>::leftJoin()             
         expects string|null, Illuminate\Database\Query\Expression given.  
 403    Parameter #1 $columns of method                                                                                        
         Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model>::whereNull()                                  
         expects array<string>|string, Illuminate\Database\Query\Expression                                                     
         given.