search

wrmacdonald / gift-app

1 stars 0 forks source link

Add db columns #26

Closed wrmacdonald closed 2 years ago

wrmacdonald commented 2 years ago

Added many db columns to user, group, & item

mgnielsen1 commented 2 years ago

My thought was that activated is always defaults to false and is only set to true once the user confirms their email. Just thinking now though that since there are multiple ways of becoming a user there may be a better way to do it. Maybe having a user.status_code with a few options or something similar. Let’s open an issue for this to decide the best way to do it.

On Tue, Apr 5, 2022 at 10:57 AM wrmacdonald @.***> wrote:

@.**** commented on this pull request.

In gift-app/database/models/models.py https://github.com/wrmacdonald/gift-app/pull/26#discussion_r843113889:

 last_name = Column(String(254))
  • email_address = Column(String(254))
  • hashed_password = Column(String(254))
  • time_created = Column(DateTime(timezone=True), server_default=func.now())
  • is_activated = Column(Boolean)

I think it's fine to have it default to False, but what are we thinking "is_activated" should be used for? My thought is when someone adds emails to invite people to a group, we'll add those emails into the db with is_activated=false. Then when people sign up we'll check for whether their email already exists in the db, & if it does, change is_activated=true while adding all the other info? But when people just sign up and their email isn't in the db yet, we'll add them with is_activated=true. Does that match your idea?

— Reply to this email directly, view it on GitHub https://github.com/wrmacdonald/gift-app/pull/26#discussion_r843113889, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANESLJYI3YEZ6SJTAYNTVXLVDR5J7ANCNFSM5SRMCNNQ . You are receiving this because your review was requested.Message ID: @.***>