search

wroberts / fsed

Aho-Corasick string replacement utility
MIT License
23 stars 6 forks source link

end2end failure #2

Open jayvdb opened 5 years ago

jayvdb commented 5 years ago

I am looking at packaging this for openSUSE, and ran into the following test failure on Python 2 and 3 https://build.opensuse.org/package/show/home:jayvdb:py-new/python-fsed

[   18s] FAIL: test_end2end (fsed.tests.test_fsed.TestFsed)
[   18s] ----------------------------------------------------------------------
[   18s] Traceback (most recent call last):
[   18s]   File "/home/abuild/rpmbuild/BUILD/fsed-0.5.3/fsed/tests/test_fsed.py", line 172, in test_end2end
[   18s]     self.assertEqual(exit_code, 0)
[   18s] AssertionError: 2 != 0

All other tests pass, as can be seen at the logs in the openSUSE build systems URL above.

wroberts commented 5 years ago

Thanks for the report, @jayvdb

I guess what's happened is I forgot a few test files in the release. I've tried adding in a bunch more and released v0.5.4 today. Can you test again and see if this corrects the issue?

jayvdb commented 5 years ago

Looking better. Still an error on python 3.4

https://build.opensuse.org/package/show/home:jayvdb:py-new/python-fsed#

wroberts commented 5 years ago

I haven't been able to reproduce this, either on my own system or on a clean docker image. Do you have any thoughts on what could be happening here? We're failing because a nonzero exit status from running the script ... Unfortunately, the click test runner doesn't show stderr or stdout (stdout is captured, but not stderr, and we're not echoing stdout to console when the assertion fails). Is there any way you can dig into this a bit more?

jayvdb commented 5 years ago

Ya, sure, ill see what i dig up