wrobins / cordova-plugin-msal

Use the newest Microsoft MSAL library in your Cordova-based project!
Apache License 2.0
23 stars 63 forks source link

Add idToken to auth result #107

Closed zailleh closed 8 months ago

zailleh commented 1 year ago

The idToken is a part of the auth result from the MSAL libraries, @azure/msal-browser, microsoft-authentication-library-for-objc, and microsoft-authentication-library-for-android, but is not exposed by cordova-plugin-msal

This PR simply adds the idToken to the auth result for both iOS and Android and browser portions of cordova-plugin-msal

This PR addresses issue https://github.com/wrobins/cordova-plugin-msal/issues/53

peitschie commented 1 year ago

Not a maintainer, but an interested consumer of this plugin.

The code itself looks good to me!

Any chance you could add the type info into the typescript definitions at: https://github.com/wrobins/cordova-plugin-msal/blob/master/index.d.ts#L32 ?

zailleh commented 1 year ago

Not a maintainer, but an interested consumer of this plugin.

The code itself looks good to me!

Any chance you could add the type info into the typescript definitions at: https://github.com/wrobins/cordova-plugin-msal/blob/master/index.d.ts#L32 ?

Thanks @peitschie, I missed that there were ts definitions 😅. Should hopefully all be in the right place now so the response object has the idToken at the same place across the three platforms

peitschie commented 1 year ago

Thanks heaps @zailleh !

ZielonyBuszmen commented 1 year ago

When do you plan to merge it to master?