search

wrobins / cordova-plugin-msal

Use the newest Microsoft MSAL library in your Cordova-based project!
Apache License 2.0
23 stars 63 forks source link

Remove Precompiled iOS Binary #11

Closed wrobins closed 4 years ago

wrobins commented 4 years ago

Make the iOS MSAL framework pull from cocoapods or carthage.

hugoplatell commented 4 years ago

While testing and releasing our app, we found multiple issues with the precompiled iOS binary. It blocks running on iOS 12, the app crashes directly after startup. Furthermore, you're not allowed to run your project in an iOS simulator...

After some investigation, I removed the precompiled library from the plugin and pulled the library directly from cocoapods. This solved for us the above mentioned problems. I opened a PR #25 with my code, it is not fully tested. I only tested our implementation of B2C login.

wrobins commented 4 years ago

Thanks for fixing this! So far it doesn't seem like there are any immediate issues with the new iOS implementation so I'll close this. Thanks!