search

wrobins / cordova-plugin-msal

Use the newest Microsoft MSAL library in your Cordova-based project!
Apache License 2.0
23 stars 63 forks source link

Correctly document cordova dependencies #87

Closed peitschie closed 2 years ago

peitschie commented 2 years ago

Hi @wrobins

Just noticed in passing that master moved the cordova requirements into the "dependencies" section, which suddenly starts installing a whole raft of additional packages.

I've tweaked this so it hopefully aligns as per https://cordova.apache.org/docs/en/10.x/guide/hybrid/plugins/index.html#specifying-cordova-dependencies .

Also, do you have a timeline for when an official release (or at least another alpha build) might drop?

Thanks for the work on the plugin here!

wrobins commented 2 years ago

Hi @peitschie!

Thanks for the fix and for supporting this plugin!

Indeed - apologies for the lack of development this past year; my day job plus a few other things have taken up most of my time and I haven't been able to work on this plugin as much as I would have liked. However, that said, I have recently started back up these last couple of weeks and we should see a release "soon™" with browser support, with Windows support hopefully following shortly thereafter. I've also seen a few requests for dynamically setting the Client ID at runtime, which wasn't possible initially because of an Android limitation. However, I've looked and it looks like the Android MSAL library supports that now, so I'm going to add that here soon, too.

peitschie commented 2 years ago

No worries at all @wrobins ! As a working professional, I can completely appreciate and understand how many of these things can only have sustained development when they align with the day job 😄

I appreciate all the work you've done here! Please don't consider my question anything other than an expression of interest in your work 🙂