This fixes the issue of Vincent not working when the IPython notebook is on https. This is the case when running a from a remote server. Instead of using urls that start with 'http://' they just start with '//'. The browser then uses the protocol currently in use.
This issue has been discussed previously in #64 which was closed with the intent of making a more comprehensive solution to how external JS files are loaded. This current PR is more minor in scope in comparison. The JS libraries are still loaded remotely, it just loads from http or https appropriately.
Some caveats:
The urls I am using all have specific versions of the external libraries. I don't know if this is ideal or if the versions I picked (the latest) are compatible with all the features of Vincent.
My testing was pretty limited. I was working on a problem with NetworkX in the IPython notebook with a remote server. If there is a check list for a PR I'll be happy to be a better tester.
wrobstory
commented
9 years ago
This fixes the issue of Vincent not working when the IPython notebook is on https. This is the case when running a from a remote server. Instead of using urls that start with 'http://' they just start with '//'. The browser then uses the protocol currently in use.
This issue has been discussed previously in #64 which was closed with the intent of making a more comprehensive solution to how external JS files are loaded. This current PR is more minor in scope in comparison. The JS libraries are still loaded remotely, it just loads from http or https appropriately.
Some caveats: