search

wrpearson / fasta36

Git repository for FASTA36 sequence comparison software
Apache License 2.0
117 stars 17 forks source link

name function error nmgetlib.c #44

Closed Zombach closed 1 year ago

Zombach commented 2 years ago

Non-existent function error preventing compilation on Windows

wrpearson commented 2 years ago

While this change allows fasta36 to compile under Windows, it does not provide the appropriate functionality, and breaks things for Unix like operating systems that provide popen().

Better would be to replace "popen" with "_popen" for Windows compilation, inside an #ifdef.

ifdef UNIX

libf=popen(acc_script,"r");

endif

ifdef WIN32

libf=_popen(acc_script,"r");

endif

Begin forwarded message:

From: ZLoo @.**@.>>

Subject: [wrpearson/fasta36] Update nmgetlib.c (PR #44)

Date: August 31, 2022 at 1:15:03 AM MDT

To: wrpearson/fasta36 @.**@.>>

Cc: Subscribed @.**@.>>

Reply-To: wrpearson/fasta36 @.**@.>>

Non-existent function error preventing compilation on Windows

You can view, comment on, or merge this pull request online at:

https://github.com/wrpearson/fasta36/pull/44

Commit Summary

File Changes

(1 filehttps://github.com/wrpearson/fasta36/pull/44/files)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/wrpearson/fasta36/pull/44, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABQYNPYF47LVK2MWI5FGM2TV34A7PANCNFSM6AAAAAAQBCYH74. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Zombach commented 2 years ago

@wrpearson Thank you for your reply. Indeed, this would be the best solution.