listout commented 2 months ago

On musl the functions fseeko and ftello are under include a few include guards

#if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
 || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) \
 || defined(_BSD_SOURCE)
...
int pclose(FILE *);
int fileno(FILE *);
int fseeko(FILE *, off_t, int);
off_t ftello(FILE *);
...
#endif

This results in build failure on musl systems such as

x86_64-pc-linux-musl-gcc -O2 -pipe -march=native -fno-diagnostics-color -msse2 -ffast-math  -O2 -pipe -march=native -fno-diagnostics-color -msse2 -ffast-math -g -std=c99 -O  -DPOSIX_C_SOURCE=2 -DSHOW_HELP -DSHOWSIM -DUNIX -DTIMES -DHZ=100 -DMAX_WORKERS=8 -DTHR_EXIT=pthread_exit  -DM10_CONS  -D_REENTRANT -DHAS_INTTYPES -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DUSE_FSEEKO -DSAMP_STATS -DPGM_DOC -DUSE_MMAP  -D_LARGEFILE64_SOURCE  -DBIG_LIB64 -c nmgetlib.c -o lgetlib.o In file included from altlib.h:46,
                 from nmgetlib.c:94:
nmgetlib.c: In function 'agetlib':
mm_file.h:32:15: error: implicit declaration of function 'ftello'; did you mean 'ftell'? [-Wimplicit-function-declaration]
   32 | #define FTELL ftello
      |               ^~~~~~
nmgetlib.c:596:47: note: in expansion of macro 'FTELL'
  596 |       if (lm_fd->libf != stdin) lm_fd->lpos = FTELL(lm_fd->libf);
      |                                               ^~~~~
nmgetlib.c: In function 'aranlib':
mm_file.h:31:15: error: implicit declaration of function 'fseeko'; did you mean 'fseek'? [-Wimplicit-function-declaration]
   31 | #define FSEEK fseeko
      |               ^~~~~~
nmgetlib.c:715:5: note: in expansion of macro 'FSEEK'
  715 |     FSEEK(lm_fd->libf, seek, 0);
      |     ^~~~~

My patch adds -D_BSD_SOURCE to the linux Makefile and thus fixes the bug Reported on Gentoo Linux with musl libc (or musl profile) Please refer: https://bugs.gentoo.org/938324

listout commented 2 months ago

I'm very much open to better alternative/ideas.

wrpearson commented 2 months ago

Thank you. I have accepted your suggested change, and hopefully the change has been merged.

Bill Pearson

Begin forwarded message:

From: Brahmajit Das @.**@.>>

Subject: [wrpearson/fasta36] Fix building on musl libc (PR #64)

Date: August 30, 2024 at 5:20:37 AM MDT

To: wrpearson/fasta36 @.**@.>>

Cc: Subscribed @.**@.>>

Reply-To: wrpearson/fasta36 @.**@.>>

On musl the functions fseeko and ftello are under include a few include guards

if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \

|| defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) \ || defined(_BSD_SOURCE) ... int pclose(FILE ); int fileno(FILE ); int fseeko(FILE , off_t, int); off_t ftello(FILE ); ...

endif

This results in build failure on musl systems such as

x86_64-pc-linux-musl-gcc -O2 -pipe -march=native -fno-diagnostics-color -msse2 -ffast-math -O2 -pipe -march=native -fno-diagnostics-color -msse2 -ffast-math -g -std=c99 -O -DPOSIX_C_SOURCE=2 -DSHOW_HELP -DSHOWSIM -DUNIX -DTIMES -DHZ=100 -DMAX_WORKERS=8 -DTHR_EXIT=pthread_exit -DM10_CONS -D_REENTRANT -DHAS_INTTYPES -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DUSE_FSEEKO -DSAMP_STATS -DPGM_DOC -DUSE_MMAP -D_LARGEFILE64_SOURCE -DBIG_LIB64 -c nmgetlib.c -o lgetlib.o In file included from altlib.h:46, from nmgetlib.c:94: nmgetlib.c: In function 'agetlib': mm_file.h:32:15: error: implicit declaration of function 'ftello'; did you mean 'ftell'? [-Wimplicit-function-declaration] 32 | #define FTELL ftello | ^~ nmgetlib.c:596:47: note: in expansion of macro 'FTELL' 596 | if (lm_fd->libf != stdin) lm_fd->lpos = FTELL(lm_fd->libf); | ^~~~~ nmgetlib.c: In function 'aranlib': mm_file.h:31:15: error: implicit declaration of function 'fseeko'; did you mean 'fseek'? [-Wimplicit-function-declaration] 31 | #define FSEEK fseeko | ^~ nmgetlib.c:715:5: note: in expansion of macro 'FSEEK' 715 | FSEEK(lm_fd->libf, seek, 0); | ^~~~~

My patch adds -D_BSD_SOURCE to the linux Makefile and thus fixes the bug Reported on Gentoo Linux with musl libc (or musl profile) Please refer: https://bugs.gentoo.org/938324

You can view, comment on, or merge this pull request online at:

https://github.com/wrpearson/fasta36/pull/64

Commit Summary

0bc5fb2https://github.com/wrpearson/fasta36/pull/64/commits/0bc5fb2874e399e7a397ad015b155da5527f837b Fix building on musl libc

File Changes

(1 filehttps://github.com/wrpearson/fasta36/pull/64/files)

M make/Makefile.linux64_sse2https://github.com/wrpearson/fasta36/pull/64/files#diff-19b1cd669a0148adf1f34351bfdc50242f91720e41244a6e03212faed35847b4 (2)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/wrpearson/fasta36/pull/64, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABQYNP3PX2BCWEUYN67VXWLZUBIQLAVCNFSM6AAAAABNMI66B6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4TMOJWGA2TEOA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

wrpearson / fasta36

Fix building on musl libc #64

if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \

endif