search

wrycu / StarWarsFFG-Enhancements

Module intended to provide minor enhancements for the Foundry VTT FFG Star Wars system
MIT License
18 stars 18 forks source link

[Compatability] JB2A Patreon Pack #27

Closed Havoclivekiller closed 3 years ago

Havoclivekiller commented 3 years ago

I've the patreon pack of JB2A animations but the module requires me to use the non-patreon version. Won't launch without it.

wrycu commented 3 years ago

Yeah, I'm looking for a better solution for this. The problem is that you can't declare optional dependencies and can't allow >1 module to fulfil a dependency. The other way I can think of doing it is to not require JB2A at all, but that results in a worse UX for users who don't have either.

I'm open to ideas on how to solve this, if you have any.

Havoclivekiller commented 3 years ago

My suggestion is to remove the dependency. Have a popup when a Gamemaster logs in with the Star Wars Enhancement info, there you could have a warning that the module has animations but needs JB2A pack (patreon or not). Disable all animations until the module detects the JB2A is activated.

wrycu commented 3 years ago

Done. Will be released in 0.1.8.