Save files tests

[Utumno]

• [ ] We need an array of saves for each supported games that are small enough to be committed to this repository - @arthmoor can you do that ?
• [ ] tests for reading the header (save_files.py)
• [ ] tests for _saves.py along with refactoring this a la bsa_files.py - see: https://github.com/wrye-bash/wrye-bash/issues/349

@nycz - I saw you have written code for save faces https://github.com/nycz/FaceTransfer - saves handling refactoring (see https://github.com/wrye-bash/wrye-bash/issues/349) and extending saves code for new games are major goals for 308 - so if interested to jump into that that would be great. Meanwhile I will grant you write rights in this repo in case you want to proceed with testing saves.

[nycz]

a bunch of small saves to test with would be really swell, would make tests a lot easier to whip up. the lack of them has been one of the reasons i haven't gotten far with testing the l4z code yet.

nice, i'll look at the save handling :) would be a shame to let all my many late hours staring at hexdumps of skyrim saves go to waste after all

[Utumno]

Excellent - I would like this be build from the ground up. Basically I have built an bsa files hierarchy I am quite satisfied with - would like this be done with saves - won't be a one night's work I warn you :P

I have already written the header's hierarchy replacing a lot of duplicate/ugly code with much cleaner one: https://github.com/wrye-bash/wrye-bash/commit/d94250c78ebd7feaba687104918babba5dc1545e, https://github.com/wrye-bash/wrye-bash/commit/a824289a265d461ec6b3d310bf885cea2f422868.

Next step would be to (in parallel):

• start writing tests for the header's code in save_files.py
• gradually move stuff from intentionally ugly named _saves.py into save_files.py in a hierarchy that mimics https://github.com/wrye-bash/wrye-bash/blob/48427d33a953804bb5084492645983645f59964f/Mopy/bash/bosh/bsa_files.py.

That's interesting refactoring work, needs thought - and will permit us to later easily extend save files functionality for all games - but you know, 1% inspiration 99% perspiration :)

Master issue https://github.com/wrye-bash/wrye-bash/issues/349 - in the backburner but not quite ;)