search

wrye-bash / wizparse

ANTLR-based parser for BAIN wizards
MIT License
4 stars 0 forks source link

Is test.txt semantically valid? #6

Closed Holt59 closed 3 years ago

Holt59 commented 3 years ago

According to the README (eh... ), Note should be followed by something that evaluates to a string.

In test.txt, it contains 3 + 6 * 2, which obviously is not a string. Is this a simple mistake when writing the test or is this a test that actually passes with the current interpreter?

Infernio commented 3 years ago

The implementation is '- %s\n' % note, so literally anything that can be converted into a string is accepted by the current parser. If that should be the case is a different question, but I would lean towards 'yes' here actually.

Holt59 commented 3 years ago

I just tested and indeed the current version of Wrye Bash convert everything to string.