search

wrye-bash / wrye-bash

A swiss army knife for modding Bethesda games.
https://wrye-bash.github.io
GNU General Public License v3.0
455 stars 79 forks source link

Add support for the GOG versions of Bethesda games #646

Closed Infernio closed 1 year ago

Infernio commented 1 year ago

Todd's done it again. Yet another rerelease of Skyrim on yet another platform.

Detailed information available here: https://github.com/loot/loot/issues/1802

Should be really easy to support, thankfully.

Infernio commented 1 year ago

See #648, if Beth start releasing other games on GOG as well soon I'll repurpose this issue to be about all of them.

Infernio commented 1 year ago

And just like that, renaming is needed since Nehrim and Enderal have been released on GOG.

sibir-ine commented 11 months ago

Not sure when this happened, but FO3 & FNV are on GOG, as is Morrowind, though I understand that support for it is limited at the moment. LOOT stores the GOG game IDs & registry keys here, & the IDs can be used for unique icon files of the form goggame-<GOG ID>.ico to identify GOG installs as I'm not sure if they also have a gog.ico file. I believe they have the same AppData & My Games folders as their Steam variants. IIRC, @Ortham has them, so maybe they'd be able to confirm.

Ortham commented 11 months ago

IIRC, @Ortham has them, so maybe they'd be able to confirm.

I've got Morrowind, Oblivion, Nehrim, Skyrim SE, Enderal, Fallout 3 and Fallout New Vegas on GOG (i.e. all the games that are currently sold on GOG). Not all the games on GOG have a gog.ico file (e.g. Morrowind doesn't), that's why I went for using the game-specific icon files to tell if an install is a GOG install.

Utumno commented 11 months ago

Thanks @Ortham @sibir-ine - do you think this is easily done @Infernio ?

Infernio commented 11 months ago

Should be straightforward, modulo some refactoring to support the different icons directly in GOGMixin. I'll take a look later today (but obviously won't be able to test it).

Utumno commented 11 months ago

Thanks Inf - other than that I think from my side I have nothing else 311 related - 647 should be stable as far as loading is concerned, now that we parsed the WRLD children - in the patch API (keepRecords and co) there might be some buggy edge cases but this is (#)312 so we'll have plenty of chances to revisit. I will have some time during the weekend - anything you want help with ping me

Infernio commented 11 months ago

Do the FO3/FNV games still have the different language directories in their GOG versions?

Ortham commented 11 months ago

No, they have separate installers for each language.