wrye-bash / wrye-bash

A swiss army knife for modding Bethesda games.
https://wrye-bash.github.io
GNU General Public License v3.0
455 stars 79 forks source link

Restrict red background highlighting to timestamp conflicts #656

Closed Infernio closed 1 year ago

Infernio commented 1 year ago

Right now we use it for:

Problems with this:

  1. The first one isn't nearly as bad as the second one - if you're not using a BP, there is no point in ever worrying about it and you might as well just set the color to white in the settings. Plus the BP already gives you a prompt to deactivate all Deactivate-tagged ones. And the Plugin Checker warns too. And we mark the plugin in italics.
  2. The highlighting makes the entry pretty much unreadable, especially if you are visually impaired or colorblind.
  3. The fact that these two problems are the ones that get this highlighting is odd. There are some much more serious issues that WB does not highlight this way (active plugin with missing masters, Skyrim LE BSA on Skyrim SE, etc. - those cause crashes, but we don't do any kind of weird highlight there).

As a result, people keep getting confused by this.

So my proposal is:

image

(lighter color is inactive mtime conflict, darker color is active mtime conflict)

Infernio commented 1 year ago

See c6fc9696d324d1b6a5b61aaaeeb50d0fc069816f for a draft implementation. This is a discussion though, so please do give feedback.

Utumno commented 1 year ago

Good solution 👍 people keep getting confused over the "Two plugins share the same mtime." color also - could be worth it to actually redate the mods on version changed but laterzzz