search

wrye-bash / wrye-bash

A swiss army knife for modding Bethesda games.
https://wrye-bash.github.io
GNU General Public License v3.0
455 stars 79 forks source link

Add commit sha to the nightly builds #675

Open Utumno opened 4 months ago

Utumno commented 4 months ago

Doesn't need to be the full sha ten chars should be enough - helpful to track where a nightly was built from since we (wisely) stopped pushing the build commit to nightly.

Infernio commented 4 months ago

Definitely a good idea. Note the comment though:

https://github.com/wrye-bash/wrye-bash/blob/8a11027e57b942d5ae084a3a81bafdf4bd5884b6/Mopy/bash/bass.py#L40

Some scripts rely on this for sure, not sure what else does. It might be best to create a new app_version_extra string constant and format with that, like this:

f'{bass.AppVersion}-{bass.app_version_extra}'

Then log that in the BashBugDump instead of bare AppVersion, same with the title bar. Would also let us easily add RC1 etc. to release candidates.

Or maybe do the formatting right in bass? Not sure what's better.

Metallicow commented 3 months ago

... OK? Do I want this? Is there a Dynamic way to update the 'built' status to a customer besides saying OK go here click that...

... other than noob-automated principles besides "Nightly" ...