search

wryun / es-shell

es: a shell with higher-order functions
http://wryun.github.io/es-shell/
Other
307 stars 25 forks source link

`eval {}` is broken now #104

Closed jpco closed 1 month ago

jpco commented 1 month ago

Somehow #69 broke eval pretty badly, such that now I'm seeing

; eval {}
var.c:240: assertion failed (rootlist == &push->defnroot)
IOT instruction--core dumped

So. Oops.

Just based on which lines of code were touched by each commit, it seems like it should have been #88 that did it, but actual git bisection says otherwise.

Incidentally, I just noticed that trip.es has several calls to eval, but none of them are of the form eval {...}! So that seems like a gap to fix.

wryun commented 1 month ago

Revert first, ask questions later :) Thanks for tracking it down.