search

wryun / es-shell

es: a shell with higher-order functions
http://wryun.github.io/es-shell/
Other
307 stars 25 forks source link

Always use va_copy (musl support) #25

Closed eadwardus closed 2 years ago

eadwardus commented 5 years ago

As the code already assumes that va_start and va_end exists (even when stdarg_h is not defined) i think that using va_copy by default won't cause any regression, but to guarantee i added some defines when stdarg_h is not defined (those definitions works because the compiler export _va*)

Also should fix issue #24 (actually i'm not sure, as the person said that changing to va_copy weren't enough, but in my machine i was able to build it with musl)

edit: i tested on adelie linux, and in fact the master branch compiles with this minimal change

msiism commented 5 years ago

i tested on adelie linux, and in fact the master branch compiles with this minimal change

Indeed. (The other issue was just that I was missing Yacc.)

Thanks!

hyphenrf commented 3 years ago

Tested this on Alpine and it builds fine :) thanks!

wryun commented 2 years ago

Sorry, completely forgot about this. Makes sense to me.