wsaunders1014 / ShowDragDistance

Shows distance you dragged the token, similar to pressing ctrl.
10 stars 13 forks source link

Not able to drag tokens on Version 9, Dnd5e #106

Open shecrio opened 2 years ago

shecrio commented 2 years ago

Console drops first two errors on click, third on letting off the click.

showdragdistance.js:472 Uncaught TypeError: Cannot read property '_onDragStart' of null [Detected 1 package: ShowDragDistance] at Token5e.Token._onDragLeftStart (showdragdistance.js:472) at MouseInteractionManager.callback (foundry.js:24060) at MouseInteractionManager._handleDragStart (foundry.js:24377) at MouseInteractionManager._handleMouseMove (foundry.js:24359) at e.a.emit (index.js:202) at r.dispatchEvent (interaction.min.js:8) at r.processPointerMove (interaction.min.js:8) at t.recursiveFindHit (interaction.min.js:8) at t.findHit (interaction.min.js:8) at r.processInteractive (interaction.min.js:8) at r.onPointerMove (interaction.min.js:8) 9 showdragdistance.js:479 Uncaught TypeError: Cannot read property 'active' of null [Detected 1 package: ShowDragDistance] at Token5e.Token._onDragLeftMove (showdragdistance.js:479) at MouseInteractionManager.callback (foundry.js:24060) at MouseInteractionManager._handleDragMove (foundry.js:24390) at MouseInteractionManager._handleMouseMove (foundry.js:24364) at e.a.emit (index.js:202) at r.dispatchEvent (interaction.min.js:8) at r.processPointerMove (interaction.min.js:8) at t.recursiveFindHit (interaction.min.js:8) at t.findHit (interaction.min.js:8) at r.processInteractive (interaction.min.js:8) at r.onPointerMove (interaction.min.js:8) showdragdistance.js:498 Uncaught TypeError: Cannot read property 'active' of null [Detected 1 package: ShowDragDistance] at Token5e.Token._onDragLeftDrop (showdragdistance.js:498) at MouseInteractionManager.callback (foundry.js:24060) at MouseInteractionManager._handleDragDrop (foundry.js:24433) at MouseInteractionManager._handleMouseUp (foundry.js:24403) at Token5e.a.emit (index.js:181) at r.dispatchEvent (interaction.min.js:8) at r.processPointerUp (interaction.min.js:8) at t.recursiveFindHit (interaction.min.js:8) at t.recursiveFindHit (interaction.min.js:8) at t.recursiveFindHit (interaction.min.js:8) at t.recursiveFindHit (interaction.min.js:8) at t.recursiveFindHit (interaction.min.js:8) at t.findHit (interaction.min.js:8) at r.processInteractive (interaction.min.js:8) at r.onPointerComplete (interaction.min.js:8) at r.onPointerUp (interaction.min.js:8)

drkranger71 commented 2 years ago

Can confirm this issue. With this mod active, mouse click and drag doesn't work at all.

iamthetot commented 2 years ago

Also have this issue. Same details.

brucetony commented 2 years ago

I think the maintainer has abandoned this project, there have been no updates to the code or issues, and none of the pull requests have been accepted in over a year. May need to look at forks and other options

brucetony commented 2 years ago

Hi all, I decided to create a fork of the repository and compile the changes @749 made into an installable module. I haven't performed any hardcore testing, but it works for now with v9. Here is the link to the manifest that you can use to download it: https://raw.githubusercontent.com/brucetony/ShowDragDistance/main/module.json

brucetony commented 2 years ago

I discovered some kind of bug with the version I provided. It is clashing with another module and creating duplicate frames.

drkranger71 commented 2 years ago

Can confirm the bug...but it only seems to occur when a token name is displayed.

brucetony commented 2 years ago

Update: I fixed the bug and the module is now working again with v2.3.2 on my fork.

DanyRamdas commented 2 years ago

Update: I fixed the bug and the module is now working again with v2.3.2 on my fork.

Tnx for the fork live saver! Here to say tnx!