wschoenell / chimera_imported_googlecode

Automatically exported from code.google.com/p/chimera
GNU General Public License v2.0
0 stars 1 forks source link

Chimera scripts don't allow multiple non-conflicting action requests #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Some Chimera scripts don't allow the user to perform multiple
non-conflicting action requests. For example:
- chimera-focus -i --in 5 ought to provide information about the focuser's
new position after moving it, but doesn't move it at all.
- chimera-dome --open --track ought to open the dome and initialize
tracking, but it only does one.
- chimera-tel --slew --ra nn:nn:nn --dec nn:nn:nn --track ought to slew and
enable tracking, but it doesn't
- chimera-cam --info --filters will display general camera info, but
nothing about filters

The scripts should be reworked to allow multiple non-conflicting actions to
take place.

Original issue reported on code.google.com by laughing...@gmail.com on 9 Jun 2008 at 4:54

GoogleCodeExporter commented 9 years ago
The problem with multiple requests is that the interpretation can lead to 
problems,
for instance, in your example: chimera-focus -i --in 5, should focuser first 
move and
then show information, why not the opposite? Strict command line ordering 
sounds good
to me, you --info --in 5 passed, show info and the move is the right order, even
thinking that the user might want the opposite.

I agree that from the other examples, user can save some time, but 
implementation
should take great care to make things in the right order (if any).

Original comment by ph.silva on 9 Jun 2008 at 6:34

GoogleCodeExporter commented 9 years ago

Original comment by ph.silva on 9 Jun 2008 at 6:44

GoogleCodeExporter commented 9 years ago
Perhaps this should be made part of the script framework; each module utilizing 
the
framework can specify their allowed actions, and perhaps assign each action a
lockoutID; only one action with a given lockoutID would be allowed.

Made low priority as new scripts are being taken care of by ph.silva and this 
would
probably be dealt with there.

Original comment by laughing...@gmail.com on 16 Jul 2008 at 7:46

GoogleCodeExporter commented 9 years ago
As of r277 on chimera-new-scripts branch, new scripts infrastructure are feature
complete and includes support for multiple (non conflicting) options (called 
Actions
Groups). This bug will be closed as soon as we merge this branch back in trunk 
(soon
this week).

Original comment by ph.silva on 28 Jul 2008 at 5:52

GoogleCodeExporter commented 9 years ago
Changes merged on r400.

Original comment by ph.silva on 25 May 2010 at 4:22